AFA Setup help - morelibspace

[jmbattle]

Piru and Bernd, working together - the next AfA_OS is going to be bloody terrific!

Keep up the good work chaps,
James
x

[klesterjr]

@jmbattle

Piru and Bernd, working together

Hmmm ...

I wouldn't work with anyone who had just thoroughly trashed my work in a public forum.

[itix]

I wouldn't work with anyone who had just thoroughly trashed my work in a public forum.

Pointing out serious bugs is not trashing.

[pVC]

Especially when code is presented in public forum. Would be harmful to leave serious bugs uncommented.

[klesterjr]

@itix

Pointing out serious bugs is not trashing.

No -- but doing it in the manner Piru did is (in MY opinion).

An e-mail would have been more appropriate (in MY opinion).

[Piru]

@klesterjr

So why didn't you email or send private message to me then?

But hey don't worry, you don't need to work with me.

Anyhow, if you would have followed my earlier posts to any coding related threads, you'd noticed that I'm rather pedantic about coding. I am quite direct when pointing out errors, too. I was quite apalled to find out how broken this particular code was, so my comments probably were even stronger than usual.

If someone feels offended, well I'm sorry I hurt your feelings. The bugs are real though, and should be fixed.

[AmiKit]

Easy guys. I am sure Piru didn't mean it bad. His comments already helped to enhance Amijeweled code and I hope for the same with the AfA_OS.

[Coolit]

Yup I'm sure Piru's comments will help get the compatibility sorted with AFA_OS.

I have to say I'm pretty surprised this incompatibility hasn't been talked about on here before, Blizkick is such a widely used program!

[unusedunused]

>Especially when code is presented in public forum. Would be harmful to leave serious bugs uncommented.

Thats the reason i post that code, maybe get some hints doing it better.

>[code...]

Eeek, what a hack.

Yes, maybe, reason is i never see any code in RKM how to write a resident module at Priority 70 style conform.
amigaOSrom patch or filesystems use a lower priority and are nort so critical.

If you can post me such clean resident code snipped i can rework that  

>- If any library possize is different from the hardcoded values used to catch the specific libraries,
>the library will not be patched. I can see this causing problems with some diskfont.library versions for example

Most( i know nobody that use old libs) users  use the newest library.I dont want increase all library space
every AFA modul check if the library space is enough and give output in snoopdos.read the first post what happen

>- Weird: Why is the every patched library possize expanded to 10KB?
>I can't possibly see any reason for that (surely AFA isn't doing any dirty tricks with library possize area?).

I see no way doing it better when the design goal is that morelibsapce should work with all existing and future AFA OS.

The fixed size is choose for simplify this.It is choosen that there need not every new AFA release a new morelibspace
and users can get trouble because of wrong morelibspace or i can forget release new version.

AROS iconlibrary for example have in the positive lib space a hash table of 5000 bytes of size.This must fit in the library

The rule i use is largest library size i ever see *2.

This mean if the largest AOS library get 2* more functions or 2* more pos libspace then a new morelibspace is need.
I see as largest library intuition library with ca. 180 funcs.so i choose 350 funcs.I see so far no other AOS with 350 funcs, maybe this limit never happen...  
 
>Frankly I don't know why it would only break with BlizKick, but I surely hope rest of AFA isn't that bad.

that happen because blitzkick seem overwrite makelibrary function.The library is not increase and so iconlib dont work.

>Hmm, think I may join the AFA forums and post there too (or maybe not as they arnt taking registrations to the forums).

The AFA forum is nonworking too much spammers want register here.I get before some days a mail  

[Coolit]

Thanks for posting back,

Ahh, I understand about your forum, just glad your checking this forum too.

Is the Blizkick compatibility issue something that will get worked on for future updates of AFA_OS? It's just I love the AA fonts and the png icons, but Blizkick is a must have part of my set-up like many other classic users.

Thanks  :-)

[unusedunused]

I read in blitzkick docu about KEEPEXEC Switch.

Maybe that help that morelibspace work.

KEEPEXEC/S
                    Try to retain exec.library and reset proof
                applications when rebooting the system. There
                really is no reason to use this switch, but
                sometimes it could be useful, if the reset
                proof application can cope ROM changing on
                them. PLEASE DON'T USE THIS SWITCH WITHOUT
                A GOOD REASON. You have been warned. Normal
                users can forget all about this switch.              

also you can try the
loadresident C:morelibspace
command in your blitzkick dir.

I cant test, because i use winuae and here come error EXTRES Buffer API not found.

I know somebody do blitzkick that work on winuae but if that feature work same as on real amiga i dont know.



 

[Piru]

@bernd_afa

Well, morelibspace should be after BlizKick to avoid excessive rebooting at power up (you should get 2 reboots then, instead of 3). In this case KEEPEXEC isn't required either.

To work reliably, the bugs should be fixed aswell.

also you can try the
loadresident C:morelibspace
command in your blitzkick dir.

This will not work with the current morelibspace. The morelibspace should have the resident tag inside it for this to work (just like any regular library or device). With this the morelibspace would work:

a) as blizkick module
b) with loadresident
c) as remus module

[quenthal]

@bernd_afa

With this the morelibspace would work:

a) as blizkick module
b) with loadresident
c) as remus module

What would be cool, is that all libraries of AFA_OS could be "ROMmable" modules, is this possible someday?

I'm sure there would be many who would use it 1) with blizkick for one boot system, or 2) with kickflash or some other flashrom-card or 3) even burn their own 1mb rom for a1200/a4000.

[Piru]

@quenthal

What would be cool, is that all libraries of AFA_OS could be "ROMmable" modules, is this possible someday?

Well, if they're regular libraries/devices/etc, then in theory it should be possible to just include them as BlizKick modules (this works for the EXTRESBUF area is it's actually RAM, not ROM).

I doubt the modules are truly (remus) "ROM"able though, for that the modules should not contain any static variables (all static variables should be in the library base). It is well possible to fix the modules to be truly "ROM"able, but might require quite a bit of adjustment of the existing AROS code.

[jmbattle]

After following this thread, I am confident that AfA_OS will continue to improve, while becoming more stable and compatible - hats off to you chaps!

Keep up the good work,
James
x

[unusedunused]

>Well, morelibspace should be after BlizKick to avoid excessive
>rebooting at power up (you should get 2 reboots then, instead of 3). In this case KEEPEXEC isn't required either.

morelibspace do no reboot when you dont use the parameter REBOOT.Only OS3.1 users must use REBOOT.

morelibspace add a resident module after load.When setpatch on OS > 3.1 do the reboot then after the reset in the
early bootphase at priority 70 it change the exec Funktion MakeLibrary.That Exec is not kill after every reset is a document AOS Feature.
Exec is only create when switch on the amiga, if the checksum is wrong or *exec\KickCheckSum is wrong.
And blitzkick seem support this with the Option.
makelibrary must patch so early because AOS create intuiton layer graphics etc libraries.
blitzkick seem use priority 0 (same as amiga rom update)or i am wrong ?.
When use priority 0 all system libraries are create and it is not possible to add new library functions to layer intuition graphics.

When blitzkick do exec not kill, then the Boot check for resident tags, find the morelibspace resident
and patch Makelibrary long time before blitzkick do any action.So all must work  

here is complete source in amiblitz.(pointers have always a * before.? is a address label

If FindResident_("morelibspace") Then End
memsize=?endresi-?begin+150+SizeOf .Resident
*kicktag.MemList=AllocMem_(memsize,$10001)
*resi.Resident=*kicktag+80
codemem.l=*resi+SizeOf .Resident
*kicktag\ml_Node\ln_Type=0;#NT_KICKMEM
*kicktag\ml_NumEntries=1
*kicktag\ml_ME\meu_Addr=*kicktag,memsize
*resi.Resident\rt_MatchWord=$4afc
*resi\rt_Flags=#RTF_COLDSTART
*resi\rt_Version=45,0,70
*resi\rt_Name=(?name-?begin)+codemem,(?name2-?begin)+codemem
*resi\rt_Init=codemem
*resi\rt_EndSkip=SizeOf .Resident;+(codemem+(?endresi-?begin +SizeOf .Resident))
*resi\rt_MatchTag=*resi
CopyMem_ ?begin,codemem,?endresi-?begin
*exec.ExecBase=execbase
*kicktag\ml_Node\ln_Succ=*exec\KickMemPtr
*exec\KickMemPtr=*kicktag
Poke.l *resi-4,*exec\KickTagPtr OR $80000000
Poke.l *resi-8,*resi
*exec\KickTagPtr=*resi-8
*exec\KickCheckSum=SumKickData_
CacheClearU_
If NumPars=1 AND Par$(1)="REBOOT" Then ColdReboot_
End

begin
MOVEM.l a0-a6/d0-d7,-(a7)
MOVE.l $4,a6
MOVE.l a6,a1
LEA newfunc(pc),a0
MOVE.l a0,d0
MOVE.l #-84,a0     ;makelibrary
JSR -420(a6)
LEA oldfunc(pc),a0
MOVE.l d0,(a0)
MOVEM.l (a7)+,a0-a6/d0-d7
RTS



newfunc
MOVEM.l d1/a1/a2/a3,-(a7)
CMP.l #1492,d0            ;diskfont
BEQ 'ok
CMP.l #134,d0             ;diskfont
BEQ 'ok
CMP.l #3150,d0            ;intuition library
BEQ 'ok
CMP.l #544,d0            ;graphics library
BEQ 'ok
CMP.l #46,d0            ;layers library
BEQ 'ok
CMP.l #348,d0           ;icon.library
BEQ 'ok
BRA 'skip
'ok
MOVEQ #0,d0
CMP.w #-1,(a0)
BNE 'dolong
MOVE.l a0,a2
ADDQ.w #2,a0
LEA funcs(pc),a1
'g1 CMP.w #-1,(a0)
BEQ 'em1
MOVE.w (a0)+,d1
EXT.l d1
ADD.l a2,d1
MOVE.l d1,(a1)+
ADDQ.l #1,d0
BRA 'g1
'em1 ADDQ.l #1,d0
LEA dummy(pc),a0
MOVE.l a0,(a1)+
CMP.l #350,d0
BNE 'em1
MOVE.l #-1,(a1)+
LEA funcs(pc),a0
BRA 'doit
'dolong


LEA funcs(pc),a1
'g2 CMP.l #-1,(a0)
BEQ 'em1
MOVE.l (a0)+,(a1)+
ADDQ.l #1,d0
BRA 'g2

'doit MOVE.l #10000,d0
'skip MOVEM.l (a7)+,a1/a2/d1/a3
MOVE.l oldfunc(pc),-(a7)
RTS
dummy: TRAP #0
       RTS
funcs: Ds.l 410
oldfunc: Dc.l 0
name: Dc.b "morelibspace",0
name2: Dc.b "morelibspace V45",0
Even
endresi

>What would be cool, is that all libraries of AFA_OS could be "ROMmable" modules, is this possible someday?

I dont know. blitzkick must support the increase of library space to have room for additional OS functions

for example AFA graphicslib support that functions but the original library creation code have no room for this functions in the library.that the functions can add is the job of morelibspace

SETFUNC(AndRegionRegionND,Graphics,GfxBase);
SETFUNC(CopyRegion,Graphics,GfxBase);
SETFUNC(NewRectRegion,Graphics,GfxBase);
SETFUNC(SetRegion,Graphics,GfxBase);
SETFUNC(ClearRegionRegion,Graphics,GfxBase);
SETFUNC(IsPointInRegion,Graphics,GfxBase);
SETFUNC(CreateRastPort,Graphics,GfxBase);
SETFUNC(FreeRastPort,Graphics,GfxBase);
}