Counting on AllocVec's size memo..

[Piru]

MAllocVec will write zeropage if AllocMem fails, fixed version:

Code: [Select]

APTR MAllocVec( unsigned long byteSize, unsigned long requirements )
{
    if (SysBase->LibNode.lib_Version >= 36)
    {
        return AllocVec(byteSize, requirements);
    }
    else
    {
        unsigned long *data;

        byteSize += sizeof(unsigned long);
        data = (unsigned long *)AllocMem(byteSize, requirements);
        if (data)
        {
            *data = byteSize;
            data++;
        }
        return data;
    }
}


Small fix to MFreeVec aswell, in case this routine is to be used as drop-in replacement for FreeVec:

Code: [Select]


void MFreeVec( APTR memoryBlock )
{
    if (SysBase->LibNode.lib_Version >= 36)
    {
        FreeVec(memoryBlock);
    }
    else if (MemoryBlock)
    {
        unsigned long byteSize;
        unsigned long *data;

        data = (unsigned long*)memoryBlock;
        data--;
        byteSize = *data;
        FreeMem(data, byteSize);
    }
}


Excuse me, I just can't help myself. ;-)

[koaftder]

I still can't get used to that leading '{' on its own line. Am I defective? Why do people do this?

[Piru]

Wikipedia: Indent Style#BSD/Allman style

Basically it's easier to read: More "spacious" and it's easier to see where blocks start and end (just find  visually matching brackets).

This is not the universally superior indent style, but it is fairly common. However, the most important thing is to stay consistent: When you choose a style, stick to it. Don't change styles (at least not within the same project).

See more at Wikipedia: Programming style

[koaftder]

Piru wrote:
Wikipedia: Indent Style#BSD/Allman style

Basically it's easier to read: More "spacious" and it's easier to see where blocks start and end (just find  visually matching brackets).

This is not the universally superior indent style, but it is fairly common. However, the most important thing is to stay consistent: When you choose a style, stick to it. Don't change styles (at least not within the same project).

See more at Wikipedia: Programming style

I guess I'm in the "BSD/KNF" camp. I guess I need to get used to the Allman style. Allman isn't easier to read to me.... I'm doing a lot of windows stuff right now and its all some perverted allman style. Driving me nuts. Especially allan style with win32 calls with 1000 parameters blocked up on multiple lines.

[CannonFodder]

koaftder wrote:
I still can't get used to that leading '{' on its own line. Am I defective? Why do people do this?

Hallelujah I am not alone in this world!

I cannot stand that.  It's ridiculous.

BSD/KNF style

Much better.

[koaftder]

CannonFodder wrote:

Hallelujah I am not alone in this world!

Much better.

you definately are not alone. I hate the single line entry '{' what a waste of space. The indent make it obvious what scope one is in. The trailing '}' is ok, it denotes down scope. Thats all you need.

[CannonFodder]

Code: [Select]


void MFreeVec( APTR memoryBlock ) {
    if (SysBase->LibNode.lib_Version >= 36) {
        FreeVec(memoryBlock);
    }

    else if (MemoryBlock) {
        unsigned long byteSize;
        unsigned long *data;

        data = (unsigned long*)memoryBlock;
        data--;
        byteSize = *data;
        FreeMem(data, byteSize);
    }
}


Much nicer. ;-)

[koaftder]

CannonFodder wrote:

Code: [Select]


void MFreeVec( APTR memoryBlock ) {
    if (SysBase->LibNode.lib_Version >= 36) {
        FreeVec(memoryBlock);
    }

    else if (MemoryBlock) {
        unsigned long byteSize;
        unsigned long *data;

        data = (unsigned long*)memoryBlock;
        data--;
        byteSize = *data;
        FreeMem(data, byteSize);
    }
}


Much nicer. ;-)

wow, I can actually read that.

[koaftder]

CannonFodder wrote:

Code: [Select]


void MFreeVec( APTR memoryBlock ) {
    if (SysBase->LibNode.lib_Version >= 36)
        FreeVec(memoryBlock);
    else if (MemoryBlock) {
        unsigned long byteSize;
        unsigned long *data;

        data = (unsigned long*)memoryBlock;
        data--;
        byteSize = *data;
        FreeMem(data, byteSize);
    }
}


sorry, had to do that.

[CannonFodder]

koaftder wrote:

CannonFodder wrote:

Code: [Select]


void MFreeVec( APTR memoryBlock ) {
    if (SysBase->LibNode.lib_Version >= 36)
        FreeVec(memoryBlock);
    else if (MemoryBlock) {
        unsigned long byteSize;
        unsigned long *data;

        data = (unsigned long*)memoryBlock;
        data--;
        byteSize = *data;
        FreeMem(data, byteSize);
    }
}


sorry, had to do that.

:lol:

[Piru]

Oh no, yet another holy war... But of course it's a matter of taste....






Except that BSD/Allman is teh bestest!!!1






:-D

[koaftder]

Piru wrote:
Oh no, yet another holy war... But of course it's a matter of taste....
Except that BSD/Allman is teh bestest!!!1
:-D

Might as well be, everybody is doing it. I'll have to learn to cope.

[CannonFodder]

Piru wrote:
Oh no, yet another holy war... But of course it's a matter of taste....


Except that BSD/Allman is teh bestest!!!1

:-D

Infidel!!! ;-)