Counting on AllocVec's size memo..

[koaftder]

OS4 broke it.

AmigaOS 2.0 to 3.9 and MorphOS have the size at -4.

[EDIT] Oh dear, this really is me, Piru.

Wayne: What the heck is going on? :-) [/EDIT]

[koaftder]

Dang it, too bad Piru noticed his session was screwed up, I almost got to look like I know what i'm talking about for once (:

[koaftder]

bytes.

(and again this was Piru)

[koaftder]

I still can't get used to that leading '{' on its own line. Am I defective? Why do people do this?

[koaftder]

Piru wrote:
Wikipedia: Indent Style#BSD/Allman style

Basically it's easier to read: More "spacious" and it's easier to see where blocks start and end (just find  visually matching brackets).

This is not the universally superior indent style, but it is fairly common. However, the most important thing is to stay consistent: When you choose a style, stick to it. Don't change styles (at least not within the same project).

See more at Wikipedia: Programming style

I guess I'm in the "BSD/KNF" camp. I guess I need to get used to the Allman style. Allman isn't easier to read to me.... I'm doing a lot of windows stuff right now and its all some perverted allman style. Driving me nuts. Especially allan style with win32 calls with 1000 parameters blocked up on multiple lines.

[koaftder]

CannonFodder wrote:

Hallelujah I am not alone in this world!

Much better.

you definately are not alone. I hate the single line entry '{' what a waste of space. The indent make it obvious what scope one is in. The trailing '}' is ok, it denotes down scope. Thats all you need.

[koaftder]

CannonFodder wrote:

Code: [Select]


void MFreeVec( APTR memoryBlock ) {
    if (SysBase->LibNode.lib_Version >= 36) {
        FreeVec(memoryBlock);
    }

    else if (MemoryBlock) {
        unsigned long byteSize;
        unsigned long *data;

        data = (unsigned long*)memoryBlock;
        data--;
        byteSize = *data;
        FreeMem(data, byteSize);
    }
}


Much nicer. ;-)

wow, I can actually read that.

[koaftder]

CannonFodder wrote:

Code: [Select]


void MFreeVec( APTR memoryBlock ) {
    if (SysBase->LibNode.lib_Version >= 36)
        FreeVec(memoryBlock);
    else if (MemoryBlock) {
        unsigned long byteSize;
        unsigned long *data;

        data = (unsigned long*)memoryBlock;
        data--;
        byteSize = *data;
        FreeMem(data, byteSize);
    }
}


sorry, had to do that.

[koaftder]

Piru wrote:
Oh no, yet another holy war... But of course it's a matter of taste....
Except that BSD/Allman is teh bestest!!!1
:-D

Might as well be, everybody is doing it. I'll have to learn to cope.