duktape error NetSurf OS3

[chris]

I looked for every files which could contain js in NetSurf but I didn't find the cause of the issue. I don't have any news about the developers (using the netsurf-dev mail list), do you have an idea about or another way to contact them ?

The other way is IRC, which is often better ('m not a fan, but it's likely you'll get a response if somebody is on)

EDIT : @chris I can see the libnsutils compilation doesn't work (so the NetSurf one too)... Do you think it could be due to the changes you've done on it ?

Yeah, I broke it, sorry  Fixed now.

Incidentally I'd be interested to hear if you have timer issues - ie. pages which refuse to finish loading, the browser just giving up loading pages after a while, etc - see http://www.amigans.net/modules/xforum/viewtopic.php?post_id=103107#forumpost103107

[chris]

I'm going to check this out. Do you have a typical website which could have this kind of behaviors ? I tried to launch twitch.tv on NetSurf windows (it's the only version available in my computer, currently, I'll test this on AmiKit later) but the page doesn't want to load totally, I guess : http://puu.sh/qxFWG/ed4bc8abae.jpg

Yes, the Sourceforge page linked to in the first post... I'm about to commit a fix based on Georg's comments which are looking good so far, so I'm confident this might be fixed.  But if you spot it behaving weirdly there's a load of logging I can enable now

I've copied up a new build for OS3 with the fixed scheduler (unfortunately doesn't appear to be the inadvertent cause of Duktape problems)

[chris]

I don't have access to it (Error 403), so I can't test... sry ! :-(

That's probably correct, it just redirects to a logon screen.

OK, please tell me when you did it, as I can launch NetScript to compile NetSurf for me again and test it on AmiKit.

It is done.

In fact, if you need some help for a french translasion, I'll be glad to help you ! ^^

There already is one, but it might need updating.

EDIT : Ah, also, I corrected some JS mistakes, mostly in the netsurf/test/javascript HTML files (I thought this was the cause of the DukTape Issue). If you want, I can give them to you.

It's best to attach that sort of thing to a bug report.

[chris]

Tested 11th August version. Colors are OK, but it is still a about 30% slower than version wich used a render library.@

Huh? This version needs guigfx/render.

[chris]

@freeaks

The intention is the builds will be from CI, the current situation is an interim measure.  The build date is in Project=>About.

I'd like to know more about the crashing, I've not seen that here.

[chris]

about the build date: the goal was to avoid unnecessary downloads and installs just to check freshness of the link..

Yes, I know, but they are split over two different servers so I can't easily fetch the filedate.  This will be irrelevant when we get CI builds.

about the crash, sur,e i'd be willing to give any output i could,
what tool do you suggest to get you more info ?
right now i can see the usual:

"NetSurf
Program failed (error #80000004)
Wait for disk activity to finish."

that probably won't help you much, i'm a bit rusty about amiga things,
what kind of tool was there, was it 'sashimi' that software that could give more detailled debug output ?

Enforcer maybe?  80000004 is an illegal instruction error apparently.  It could be the CPU, memory or - if you're using UAE - an emulation error.

[chris]

Hello World !

@chris
I would like to activate the Debug commands (DUK_D, DUK_DD, DUK_DDD, DUK_DPRINT...), but what I tried didn't work. Could you please tell me how to do ?

Add the following at the top of duk_custom.h:

Code: [Select]


#define DUK_USE_DEBUG 1
#define DUK_USE_DEBUG_LEVEL 2
#define DUK_USE_DPRINT 1
#define DUK_USE_DDPRINT 1


You might want to fiddle with the value of DEBUG_LEVEL, and either add DDDPRINT or remove DDPRINT.  The debug defines don't seem to work entirely as documented.

[chris]

i installed smartcrash, does this info helps ?
http://alturl.com/rc56g  (pic of smartcrash requester)

Means nothing to me.  Maybe somebody with 68k knowledge can decode it?

i don't think it will be useful for this but, here is the snoopdoslog:
http://paste.debian.net/789741/

Would probably have been more useful if the text wasn't all truncated at U.

Anyway, a NetSurf log would be more helpful:
netsurf -v >ram:ns.log

There isn't too much logging on exit but it might help narrow down where the crash is occurring.  I (or DNADNL) can always add more.

[chris]

OK, I did this, but it seems nothing appears between the famous rows "Creating new duktape javascript context" and FATAL 56... is it normal ?

Here is what I wrote in duk_config.h :

Code: [Select]


//DNADNL DEBUG
#define DUK_USE_DEBUG 1
#define DUK_USE_DEBUG_LEVEL 2
#define DUK_USE_DPRINT 1
#define DUK_USE_DDPRINT 1
#define DUK_USE_DDDPRINT 1


duk_custom.h, not duk_config.h
It works here, that's all I can say.

[chris]

@Tygre

Doesn't mean a thing to me. You're probably best off putting it on the netsurf-dev list (try to generate some interest), or putting it on the Duktape bugtracker https://github.com/svaarala/duktape/issues with the log.
Mention it's 68k and NetSurf, Duktape 1.5.0. See what happens.

One thing you could try first, is if you have a standalone build of Duktape 1.5.0 you could run that code through it see if the fatal error still occurs.

[chris]

Hi Chris and all!

Just to let you know that Sami replied to me very fast and very kindly with several suggestions :angel:

I tried some of his suggestions and got NetSurf and Duktape to compile and run :cool: I am now waiting for his feedback to confirm that my changes make sense or not...

Great!

Now, don't get too excited because nothing happens... I loaded various Web pages with JavaScript code and nothing happens but I believe that it could be now due to the way NetSurf handles JavaScript code? :swords:

For example, I noticed something called NETSURF_DUKTAPE_PROTOTYPE_WINDOW in the logs of Duktape... My guess is that this is the "callback" used by NetSurf to control what Duktape should do when it encounters an alert()? Any idea?

I'm not sure alert() is implemented in any visible way - I don't recall seeing any JS alerts since the changeover to Duktape.

This is a good test page:
http://www.javatester.org/javascript.html

[chris]

PS. Sami confirmed that my fix may be the best solution to get Duktape to compile and run on AmigaOS3: all in duk_config.h, DUK_F_USE_REPL_ALL must be defined by:

• defining AMIGA
  
• defining M68000
  
• changing the code #elif defined(DUK_F_AMIGAOS) && defined(DUK_F_VBCC) into #elif defined(DUK_F_AMIGAOS)
  

Let me know!

The first two were already done (well, __m68k__ instead of M68000, but no difference).
The second one appears to have fixed the problem!
Note you need to enable Javascript in NetSurf through Prefs (the menu option just crashes) as using non-JS versions tends to switch it off.

Please thank Sami and ask him to remove that DUK_F_VBCC clause in trunk. (actually, maybe it needs to be changed to DUK_F_M68K - I'll check if this has broken OS4 a bit later! edit OS4 is fine with this change)

I've updated my archive with a JS version for testing.

[chris]

I repeat:

Note you need to enable Javascript in NetSurf through Prefs (the menu option just crashes)

[chris]

Chris, how could I help further?
Could we chat by PM or e-mail, please?

Well, there's the usual stuff, and any OS3-specific bugs would be worth fixing (that JS menu item, tabs, the crash on exit that was mentioned, etc).

Of course you can email me