duktape error NetSurf OS3

[chris]

So that could mean either the problem comes from
duk_js_compile() : safe_rc = duk_safe_call(ctx, duk__js_compile_raw, 2 /*nargs*/, 1 /*nret*/);
OR from
duk_js_compile() : if (safe_rc != DUK_EXEC_SUCCESS) : duk_throw(ctx);

duk_throw is the function which triggers the fatal, which means duk_safe_call is returning something other than DUK_EXEC_SUCCESS.

It would be useful to know:
(a) what duk_safe_call is actually returning.
(b) to find out where in duk_safe_call it is returning the error.

[chris]

@chrisY: your build is faster, color are good.
is there anychance you could release a nofpu build so vampire owner could use you netsurf port ?

Are you sure the current build (test build on cy2, not the Aminet one) isn't working?

[chris]

OK, I reached the same part of code than you, chris :

Code: [Select]


if (expect >= 0 && comp_ctx->curr_token.t != expect) {
DUK_D(DUK_DPRINT("parse error: expect=%ld, got=%ld",
                (long) expect, (long) comp_ctx->curr_token.t));
DUK_ERROR_SYNTAX(thr, DUK_STR_PARSE_ERROR);
}


With Tygre, we climbed back up to this line (in duktape.c : duk__parse_func_like_fnum() ) :

Code: [Select]


duk__advance_expect(comp_ctx, DUK_TOK_RCURLY);

We think the JavaScript code used to test duktape during the NetSurf launch is responsible of the issue. Is it possible to know what is the JavaScript code executed during the NetSurf launch ? (we thought first that the NetSurf Welcome page executed Javascript code to explain the issue, but that's not the case).

However, it's quite disappointing and not handy if NetSurf crashes only because a JavaScript test script...

AFAIK it doesn't run any tests on startup.  Might be a question for the netsurf-dev mailing list (or IRC).

[chris]

I'm 99% sure that freeaks talks version here : http://www.unsatisfactorysoftware.co.uk/index.php?pg=netsurf

At least he said so in irc

That page links to both builds!
The "test build" is built with -m68020
The Aminet build probably isn't.

[chris]

I don't know how to find this IRC, so maybe I'll let you ask the question ! ^^

http://www.netsurf-browser.org/contact/

[chris]

Oh, I don't know how to compile for this, sorry... But if you have some Web links, I could go to check if I can do something, but I can't guarantee.

When somebody actually confirms if it works or not I'll commit the change. That's assuming I haven't accidentally committed it already!

[chris]

yes, about that, i have a question:
could it be possible to have netsurf to display page loading progressively ?
like every other browser on the planet?
with netsurf it feel mostly like 'all or nothing' meaning we see nothing happen, no progress and then suddenly new the page is completely loaded.
it would be better to see loading happening progressively, we would have a bit less the feeling of waiting.

I don't get you. It loads the page content+css and will display that whilst the images are queued to download.
CSS means it takes longer for the initial page to display as that needs to be parsed.
It's no different to any other CSS-supporting browser wrt initial page display.

[chris]

@freeaks

There is no point in displaying a page without CSS initially, I've never seen a browser do that. The other stuff is done already. Note that every time the layout changes the page needs to be redrawn - which makes the page take even longer. I think there are configuration options for reflowing etc.

You can watch the status bar if you want to know what it is up to.

[chris]

I've just uploaded a version which uses P96 directly on RTG screens.  I have no idea whether it will work (it is OK on AGA without P96 installed!).  If it does it should be a bit quicker, but I have a feeling the text will be all the wrong colours.

[chris]

If render.library is missing, Netsurf tells it can't found guigfx.library, even if guigfx.library is in right Place.

Actually it says it can't open guigfx.library, which is correct because guigfx.library won't open if it fails to open render.library.

[chris]

Again picture tells more than 1000 words. I tested this winuae mmu ON and no FPU like Vampire is. Works without render.library. Got same Graphics corruption with real amiga and emulated amiga. Picture is taken from real amiga screen.

That's better than I was expecting, although the corruption's a bit weird.  Hmm... probably worth just leaving it in palette-mapped mode for OS3 then.

[chris]

with latest version, netsurf don't crash anymore on exit

Interesting.

oh and i must say i prefer current status bar and scrollbars. it looks better than before.

I haven't touched these for years!

[chris]

Chris: I couldn't get tile_size_x: and tile_size_y: work. Did I remember wrong?

redraw_tile_size_x
redraw_tile_size_y

To be a fair, I tried to change ttf fonts to bitmap fonts. It has a huge performance impact for Netsurf. It didn't help a much or just tapping to "use bitmap fonts", doesn't change anything. Tried to change paths to font folder and bitmap fonts, didn't help either.

Using bitmap fonts should be the default under OS3 for a while.

Yes, toggling the bitmap fonts option does need bitmap fonts to actually be selected, otherwise it'll use the scalable ones via diskfont.library!

[chris]

once a page is finished loading, there must be some way to make the scrolling smoother, using buffered surface, and have it to buffer more a bit more than exact screen size could help maybe ?

Hmm... possibly.  The way it is written the page is drawn "JIT", and tiled rendering makes it impossible.  There's no attempt to cache any of the displayed page, even the scrolling happens direct on the window.

It has been noted before, I'm just not sure how to fix it without using oodles of memory or slowing the page draw up front.  Incidentally there's a related bug report: http://bugs.netsurf-browser.org/mantis/view.php?id=2457

[chris]

I tried to contact the NetSurf developers via their mailing list but this doesn't work "you are not allowed to post to this mailing list". How can I join them to talk about the DukTape issue, so ? Do you have an idea ?

Make sure you're subscribed to it under the email address you're sending from.

[chris]

I looked for every files which could contain js in NetSurf but I didn't find the cause of the issue. I don't have any news about the developers (using the netsurf-dev mail list), do you have an idea about or another way to contact them ?

The other way is IRC, which is often better ('m not a fan, but it's likely you'll get a response if somebody is on)

EDIT : @chris I can see the libnsutils compilation doesn't work (so the NetSurf one too)... Do you think it could be due to the changes you've done on it ?

Yeah, I broke it, sorry  Fixed now.

Incidentally I'd be interested to hear if you have timer issues - ie. pages which refuse to finish loading, the browser just giving up loading pages after a while, etc - see http://www.amigans.net/modules/xforum/viewtopic.php?post_id=103107#forumpost103107