We need an iBrowse replacement for 68k!!!

[chris]

Hook problem? Fixing the registers in all hooks could make a lot of things work .

Yes... just done it (might* have missed some, but we'll find out)

Uploaded a new version from my bitmap fonts branch (as I don't want to merge this yet).

* Actually I know I've missed some, but nothing important for now.

[chris]

Bingo!!! Most menu items and gadgets work now! It is faster than ever also. Awesome!!!

Cool.  I changed the CPU option to -m68020-60, not sure if that is the cause of the speed boost or something else.

@wawrzon

The text width etc calculations are currently somewhat broken in bitmap mode, I'm aware of that.

[chris]

probably plotting gfx elements can still be optimized

No "probably" about it, as I say graphics are still routing via DataTypes (even on high-colour screens) which is not a fast way of doing things.  What I need is an optimised RGBA=>dithered palette mapped BitMap, with optional optimised scaling built-in.  Anyone?

@chris
what was previous setting? plain -m68000?

-m68020

The one 68k build of AWeb with GCC is using:

Code: [Select]

-O2 -fomit-frame-pointer -m68020-60


I'm using:

Code: [Select]

m68020-60 -O0 -fomit-frame-pointer
So, the same basically  Be nice if somebody could give me a fix for that GCC optimisation bug, or tell me which optimisation causes it so I can disable it.

[chris]

i have an impression as if when loading the page the browser is busy looping at times, because it freezes, but it may just be high priority cpu last.

I'm getting freezing when using the diskfont code.

[chris]

I didn't mention snoopdos now, because I had already mentioned it. It crash after makedir command, next would be mime initialization.

Did you run the newer version with logging?  I added a couple of extra lines to determine whether it's the MIME part crashing.

[chris]

Seeing at least one of the taglist problems occured with NewObjectA(), you might check this:



http://guidetoamigacompatibleprogramming.googlecode.com/svn/trunk/english/CAP_2.txt

My GCC 3.4.0 version of os-include/inline/intuition.h is a little bit different if you want to try it too:

http://www.heywheel.com/matthey/Amiga/INTUITION.H

Both give me:

Code: [Select]


error: syntax error before ')' token


Where I use a NewObject embedded into an if statement.

It looks very likely to be the fix though, as all the other varargs stubs are #defined like that.  Not sure why this one isn't working.

[chris]

I wonder if there is a parsing bug in your version of GCC.

I doubt it.  There would be many more problems than this if there was.

I believe these are optional inlines instead of using the default stubs so if you can't format the function so GCC will accept it then try commenting it out.

Just get errors about there being no NewObject function.

I think all that is required is to tell GCC that the varargs are used so it doesn't optimise them away.  I can't figure out how to do that though.

[chris]

More lines may help to find what the compiler doesn't like if the line the error is on is given. If this doesn't work, maybe it would be possible to make NewObject into a regular function:

Code: [Select]

NewObject(classPtr, classID, tags...)
{
ULONG _tags[] = {tags};
NewObjectA(classPtr, classID, (const struct TagItem *) _tags);
}

I'm hoping that either the different formatting or an error message with a line number would help pinpoint the problem or, perhaps, the error would go away.

I'd tried that already (as an inline function though) and it complained that classPtr, ClassID etc weren't defined, which is an even stranger error.

[chris]

Variadic functions of Intuition were always trouble makers for different versions of GCC compilers and m68k.
Instead of creating inline code use the amiga.lib provided code, which works flawlessly for Intuition/MUI/ReAction.

Code: [Select]


#include <proto/...>
#include <proto/...>
#if defined(__GNUC__) && !defined(__amigaos4__)
#define NO_INLINE_STDARG /* Take f.e. NewObject() from amiga.lib for gcc m68k */
#include <clib/intuition_protos.h>
#include <proto/intuition.h>
#undef NO_INLINE_STDARG
#else
#include <proto/intuition.h> /* Take/Create inline code f.e. for NewObject() */
#endif
#include <proto/...>
#include <proto/...>


That might have worked, had clib2 actually had NewObject in libamiga.

I suppose I could use a different libamiga.

[chris]

That is strange. The function arguments shouldn't need defining in the function. The function needs defining which it already is in os-include/clib/inution_protos,h with the argument types given.

I think it's because "ULONG tags..." isn't a valid definition for a proper function.

I'm getting errors even when the #define is just:

Code: [Select]


({ \
})


"syntax error before ')'" and "unterminated argument list".

Code: [Select]


if((arexx_obj = ARexxObj,
AREXX_HostName,"NETSURF",
AREXX_Commands,Commands,
AREXX_NoSlot,TRUE,
AREXX_ReplyHook,NULL,
AREXX_DefExtension,"nsrx",
End))
{
...etc...


When ArexxObj is:

Code: [Select]


#define ARexxObj NewObject(ARexxClass, NULL


And End is the standard one from reaction_macros which IIRC is "TAG_END)"

[chris]

It's not possible to have all the arguments as varargs. Also, "ULONG tags ..." is not allowed with C99. C99 only allows "..." but the default GCC compile mode may have a GCCism extension which allows for better type checking.

I think it's fine for a #define, just not for a function, the two work differently.  If it wasn't then all the other varargs stub inlines would be broken too.

I've uploaded a version with the libraries built for 68020, to see whether that makes any speed difference.

[chris]

I wonder how many scalable fonts are opened still with the mapping to bitmap fonts in Choices?

If you've set the fonts to be bitmap ones, then none :-)

The NetSurf archive I downloaded today is 3104254 bytes which is the same as the one I downloaded on February 23. The executable is also the same size.

I've re-uploaded it.  Not sure what happened last time but it should be there now.

Few seconds more and computer crashes. Are those .otag fonts outlined fonts? Do I need to remove them?

Try running FixFonts.

[chris]

It's noticably faster here. NetSurf is done loading from icon in about 5 seconds and amiga.org loads in about 20 seconds. That's pretty good for not having optimizations enabled yet .

Cool.

Edit: There are still some places that are quite slow and some that may get caught in an infinite loop. I am trying to debug what looks like an infinite loop after logging into amiga.org and when being redirected back to the old thread. I see scrollbar_create(), scrollbar_make_pair() and a realloc() that I believe may be in desktop/textarea.c textarea_reflow_multiline()? Did you fix the textarea_scrollbar_callback hook for scrollbar_create()? There are several callback hooks in this vacinity which might be worth looking over. I don't get any hits but I didn't last time there was a hook problem. No hits and no freezes makes for some tough debugging.

They aren't AmigaOS hooks, so should be fine.

Edit2: I strongly believe that the infinite loop is the for loop in textarea_reflow_multiline() which starts with:

Code: [Select]

for (; len > 0; len -= b_off, text += b_off {

I can see the para_end string is "Reply" and no '\n' (newline) is found. I can't see a function name for nsfont.font_split() but there is a JSR. From there:

it looks like x is 0
(x <= h_extent) skip {}
(x <= avail_width) skip {}
(line <= ta-->lines_alloc_size - 2) skip {}
(para_end != text + b_off) skip {}
(len - b_off > 0) { for loop terminates with (space <= text) before first iteration skip {}, (space == text) skip }
(line > scroll_lines) but (ta->bar_y != NULL) skip the break;
back to the top of the for loop and repeat for infinity

Yes, that's the dodgy bitmap font code showing through.  The split function isn't working as intended (amiga_bm_nsfont_split() in font_bitmap.c).  If you disable bitmap (diskfont) fonts the infy-looping should disappear.

[chris]

I have excatly same versions of diskfon and bullet.library that you have.

diskfont.library 45.7 (01/26/02)
bullet.library 44.1 (05/01/99)

No Outline fonts and all (two) .otag fonts removed  and fixfonts runned.

No difference.

You shouldn't go around deleting .otag files.

What is happening is NetSurf has decided you have a font with no name (probably due to a corrupt font cache, .font file or a bug in my code), so it is trying to read FONTS:.otag.  This probably isn't the cause of the crash, as that file open will just fail.  There is definitely a problem with the font scanner but I don't really have anything to go on to track it down.  If you're using diskfont fonts the scan is irrelevant anyway, as it's for font substitution for characters that aren't in the current font, which isn't possible to do when all your fonts are forced into ISO-8859-1.

You can trick it into skipping the font scan by creating a file "FontGlyphCache" containing the following:
0x0000 "CGTimes"

Put that file in your user directory (PROGDIR:Users/default or whatever) and it won't scan as it'll think it already has.

I'll add something to skip the scan if outline fonts aren't being used.

[chris]

Any progress? A capable 68k solution is sorely needed.

I've not done anything further with it.  Well, actually, I tried to fix the bitmap font stuff to make line breaks work properly (and get rid of the infy loop), but I just made it worse so gave up.

[chris]

What would be facts? When starting it reguires only 5mb ram?

Try 32MB.  It just about starts with 18MB so it might be possible to get it running with that amount, but I'd suggest the minimum should be 32MB.

I requires OS3.5/3.9 maybe it will work with OS3.1 with Reaction installed? It requires AGA or RTG.

The library versions requested basically ensure that OS3.5+ is required.  Maybe it's possible to get it running under OS3.1 but the amount of stuff I've already had to backport is rather high anyway (don't let anybody tell you OS4 isn't much of an improvement over 3.1 - it has so much that makes it far easier to develop for).  AGA or RTG, both should work.

What is current state? Is it bog slow or is it "semi useable"?

No idea.

What is needed by coder?

A Linux (V)M to install the m68k toolchain on.

What are current problems?

http://wiki.netsurf-browser.org/Todo/AmigaOS_frontend#OS3_Support