@Gofromiel
Sorry, but I think you've lost the main problem in this listing... It is not possible to disassemble such code in a good way.
@Doobrey
I guess this came from times of optimalisation for plain 68000. Notice that single cmpi.w seems to be easier to execute than two artmetical operations (where both also set CC afterwards, so it is calculation + cmp for both).
But for newer processors your solution is obviously better (and much better than bra).
I think I've read also somewhere that for 68040 it is faster to have fewer, even longer commands, than more simpler.
No such problems for PowerPC code. :-)
And in the last word - to extend what Piru said about 68060 Branch Prediciton Cache - for WinUAE users:
Imagine what all this can do to JIT emutation.
Let's asume that we have even optimasing JIT, that is able even to analyse and store, if it is needed to prepare CC in the instruction (or even eliminates dead-code instructions).