As nice as the icon editors like Iconian and the OS3.9 icon editors are, I have found that the best way to make icons is to use Personal Paint, then pick up the icon as a brush and save it as an icon file. It supports normal and NewIcon icons (with the extra library). I find it's best to save the brush as a regular icon first, then save over it with the NewIcon option ticked, so the icon will work on all systems.
You can get this essential application and the extra library needed to save icons on Aminet:
http://aminet.net/package/biz/cloan/PPainthttp://aminet.net/package/biz/cloan/pio_iconOr if you're in the mood to edit the icons on your Workbench with a very handy tool, try Iconian:
http://aminet.net/package/gfx/edit/Iconian2_98u